----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review126091 -----------------------------------------------------------
Can you please split the review between the code update and the docs? The git commit hooks prevent committing accross projects (in this case Libprocess, Mesos). I would do it for you, but since this is your first commit I don't have an author to reference for committing on your behalf ;-) 3rdparty/libprocess/src/process.cpp (line 2210) <https://reviews.apache.org/r/43144/#comment189002> s/system defined/default 3rdparty/libprocess/src/process.cpp (line 2217) <https://reviews.apache.org/r/43144/#comment189003> /system defined/default 3rdparty/libprocess/src/process.cpp (line 2222) <https://reviews.apache.org/r/43144/#comment189004> New line after closing brace `}`. space between operands `num_worker_threads + 1` (I know it was incorrect before) - Joris Van Remoortere On March 30, 2016, 12:07 p.m., Maged Michael wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43144/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 12:07 p.m.) > > > Review request for mesos, Guangya Liu, Joris Van Remoortere, Klaus Ma, and > Qian Zhang. > > > Bugs: MESOS-4353 > https://issues.apache.org/jira/browse/MESOS-4353 > > > Repository: mesos > > > Description > ------- > > Added env var to set upper bound on number of libprocess worker threads. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp feaffa4 > docs/configuration.md 9ad0c2a > > Diff: https://reviews.apache.org/r/43144/diff/ > > > Testing > ------- > > Passed make check on x86_64 Ubuntu 14.04. > > Invocations of mesos-master, mesos-slave, and mesos-tests with the > LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", > "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as > expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. > The last 3 tests generated warnings. > > > Thanks, > > Maged Michael > >
