----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45489/#review126183 -----------------------------------------------------------
Patch looks great! Reviews applied: [45318, 45319, 45488, 45489] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 30, 2016, 4:16 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45489/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 4:16 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Casting from a virtual base class to a child class should not be > done with reinterpret_cast. We could use dynamic_cast as well, but > that has a performance cost; in this case, we know exactly which > child class the pointer points to, so the performance cost and > additional safety offered by dynamic_cast is not necessary. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > feaffa4334422ec3964f8d079f570061eaf390d2 > > Diff: https://reviews.apache.org/r/45489/diff/ > > > Testing > ------- > > make check with GCC 5.3 and recent apple-clang. > > > Thanks, > > Neil Conway > >
