-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45450/#review126262
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp (line 376)
<https://reviews.apache.org/r/45450/#comment189199>

    Can you test the Error case as well?


- Jie Yu


On March 29, 2016, 10:33 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45450/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 10:33 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5009
>     https://issues.apache.org/jira/browse/MESOS-5009
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> JSON::Object::find() interprets the '.' as a path into nested JSON
> objects. Add the at() helper that just indexes the top level keys
> of a JSON object with an uninterpreted key. This is helpful for
> indexing keys that contain periods.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 87d018386ea59b16bf69b529426b6567727ed545 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> 4ea610c3cd373f05843954763173b9bd51d8d5f5 
> 
> Diff: https://reviews.apache.org/r/45450/diff/
> 
> 
> Testing
> -------
> 
> Make check.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Reply via email to