-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45451/#review126263
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (lines 202 - 
209)
<https://reviews.apache.org/r/45451/#comment189200>

    Can you reorder these two:
    ```
    if (layerId.isError()) {
    } else if (layerId.isNone()) {
    }
    ```


- Jie Yu


On March 29, 2016, 10:33 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45451/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 10:33 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5009
>     https://issues.apache.org/jira/browse/MESOS-5009
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If you use the unified containerizer and the local docker puller with
> a Docker image from a private registry, the local puller fails to find
> any layers in the image's repository manifest. This happens because the
> top layer repository is qualified by the private registry name.
> 
> The fix is to also try the fully-qualified repository name if we have
> a registry name.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 74254c19a9a31cb76f09eaf1b8684610dd0d7afc 
> 
> Diff: https://reviews.apache.org/r/45451/diff/
> 
> 
> Testing
> -------
> 
> Make check. Manual testing.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Reply via email to