----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45536/#review126315 -----------------------------------------------------------
LGTM. I'll let Jie give the final ship it. src/tests/persistent_volume_tests.cpp (line 94) <https://reviews.apache.org/r/45536/#comment189266> Any specific reason why you are creating a temp directory per disk instead of a top level temp directory and well known disk directories underneath? Just curious. - Vinod Kone On March 31, 2016, 12:16 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45536/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 12:16 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-5044 > https://issues.apache.org/jira/browse/MESOS-5044 > > > Repository: mesos > > > Description > ------- > > Used Environment `mkdtemp` for temporary mounts. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 7cb153cc6c0a8ca25cd31096686c63e829f746cf > > Diff: https://reviews.apache.org/r/45536/diff/ > > > Testing > ------- > > Vverified all temporary directories are accounted for by `Environment`. > > > Thanks, > > Joris Van Remoortere > >
