----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review126477 -----------------------------------------------------------
Fix it, then Ship it! Qian, I will submit a subsequent patch to cleanup and simplify the code here. Will post the link here. Please review that patch. I'll commit it for now for this patch to avoid rebasings. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 251) <https://reviews.apache.org/r/45383/#comment189476> `+` should be in the next line. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 339 - 349) <https://reviews.apache.org/r/45383/#comment189481> It's also possible that `_cleanup` remove the interface directory and then crashes. In that case, interfaces here will be empty. Should we just ignore it (maybe print a warning)? Can you fix that in a subsequent patch? - Jie Yu On March 31, 2016, 11:33 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45383/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 11:33 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented recover() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 873e0c52475f4868e611bd24a6782ad5eb261a99 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 1c8e231813c0579b79681c5d18b1f799a727ead7 > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp > f627ec9499a34ca104d2c1a4d28e1d2f4b849f64 > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp > 611f3869402b9033081b7f9ecc1bdf006f61918b > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp > 6a3c33645bab73edaf5af4d298a671852ea59c46 > src/slave/containerizer/mesos/isolators/network/cni/spec.cpp > 5b5f904def9ef6dcc4462a03a2d024ad4eb3d946 > > Diff: https://reviews.apache.org/r/45383/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
