> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section.
Vinod?thanks for the review. I just resubmit the patch to rebase to the latest code, please take a look. Besides, do I need to submit another patch for the CHANGELOG chagnes or I can inlude the CHANGELOG changes in this patch? - zhou ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126429 ----------------------------------------------------------- On 四月 1, 2016, 5:57 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45213/ > ----------------------------------------------------------- > > (Updated 四月 1, 2016, 5:57 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-3780 > https://issues.apache.org/jira/browse/mesos-3780 > > > Repository: mesos > > > Description > ------- > > This is the first patch to solve [MESOS-3780] > > > Diffs > ----- > > src/docker/executor.cpp 26cc88d35fc7cd913c5105f5fc4e6ae71ce59279 > src/examples/balloon_framework.cpp 1665e5bd35ad9e029372e55209802c2827be658f > src/examples/no_executor_framework.cpp > 9223d954197ebd097f57efea5299c917b24fe41e > src/examples/persistent_volume_framework.cpp > 9ce43d2b7da3f03d24473ff22cb62a88004f5f53 > src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a > src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c > src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa > src/master/allocator/mesos/hierarchical.cpp > 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 > src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 > src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd > src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 > src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff > src/sched/sched.cpp d989cb5f35d314dc2e03617bfdbd4b18d4efcf91 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 323c84a3d960a196d8ba87f753814e9d43a07957 > src/slave/containerizer/mesos/launch.cpp > dc7bebf8d0f3e36c6d41af4e0e8ffc438b6cd86c > src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 > src/slave/paths.cpp e0451a8856063f78c8f2aeed11c01f3560b4ed1c > src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa > src/slave/state.cpp 75bdfe144d3307dc74bf48e6a0d403fbea568a6d > src/slave/status_update_manager.cpp > f6a9b3b6616abee9c55bf731855ee9b3b98606ac > src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 > src/tests/hierarchical_allocator_tests.cpp > 8f78a204d296f94f515f21511710a35c33e27255 > src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd > src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc > src/watcher/whitelist_watcher.cpp 3d0d5828ef095884ca87156d69f963f04dba40a1 > > Diff: https://reviews.apache.org/r/45213/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >