----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45429/#review126563 -----------------------------------------------------------
Fix it, then Ship it! Looks great! I'll fix these little bits and commit this. src/master/registrar.hpp (line 130) <https://reviews.apache.org/r/45429/#comment189589> Why a `UPID` instead of a `process::PID<RegistrarProcess> pid()`? src/master/registrar.cpp (lines 230 - 231) <https://reviews.apache.org/r/45429/#comment189588> "The authentication realm, if any, into which this process' endpoints will be installed." - Adam B On March 29, 2016, 8:46 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45429/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 8:46 a.m.) > > > Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff. > > > Bugs: MESOS-4933 > https://issues.apache.org/jira/browse/MESOS-4933 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa > src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 > src/master/registrar.hpp f087569bd6774ac16093f9204e6870e4d4404420 > src/master/registrar.cpp def40b94689c363617a7cfbcce82ea8d357cb345 > src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 > src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc > > Diff: https://reviews.apache.org/r/45429/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
