> On April 1, 2016, 7:27 a.m., Jiang Yan Xu wrote: > > src/tests/cluster.cpp, lines 434-436 > > <https://reviews.apache.org/r/44947/diff/11/?file=1320116#file1320116line434> > > > > This can be tackled in another review because a) the tests here don't > > use cluster.cpp and b) I see other issuse here as well (see below).
The isolator tests use ``cluster.cpp``. I hit this when I had a bug in those tests that passed invalid flags arguments to the Slave. Let me know whether you want me to move or just drop this diff. However, it is a fairly annoying problem to debug. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/#review126334 ----------------------------------------------------------- On April 1, 2016, midnight, James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44947/ > ----------------------------------------------------------- > > (Updated April 1, 2016, midnight) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add tests for XFS project quota utilities. > > > Diffs > ----- > > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/tests/cluster.cpp 2da0bd7612d571277e76d0a95ad8e776434af323 > src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION > src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 > > Diff: https://reviews.apache.org/r/44947/diff/ > > > Testing > ------- > > Make check. Manual testing. These tests. > > > Thanks, > > James Peach > >
