----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45590/#review126616 -----------------------------------------------------------
Patch looks great! Reviews applied: [45318, 45319, 45488, 45489, 45590] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 1, 2016, 4:22 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45590/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 4:22 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > As previously written, these tests depended on the fact that `post` > will synchronously deliver a message to a local PID. That is an > implementation detail that seems unwise to rely upon. Instead, it is > quite easy to arrange for both tests to block until the effect of > the `post` has occurred. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/process_tests.cpp > 6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd > > Diff: https://reviews.apache.org/r/45590/diff/ > > > Testing > ------- > > make check > > Without this patch, the libprocess tests fail if the "local message" > short-circuit in `transport` is disabled (circa line 556). With the patch, > the tests succeed. > > > Thanks, > > Neil Conway > >
