----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review126657 -----------------------------------------------------------
src/docker/spec.cpp (lines 103 - 105) <https://reviews.apache.org/r/44674/#comment189667> Let's remove this. I think checking if 'registry' is empty or not should be done at the upper level. If 'registry' is empty, just return None(). src/docker/spec.cpp (line 123) <https://reviews.apache.org/r/44674/#comment189666> Hum, I am thinking about returning Try<string> here. Return 'https' if port != 80 or not specified. src/docker/spec.cpp (lines 125 - 127) <https://reviews.apache.org/r/44674/#comment189665> This is not needed. src/docker/spec.cpp (line 142) <https://reviews.apache.org/r/44674/#comment189668> I think we should just return string here (instead of a Try). If registry is empty, return an empty string. - Jie Yu On April 1, 2016, 8:25 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44674/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 8:25 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4939 > https://issues.apache.org/jira/browse/MESOS-4939 > > > Repository: mesos > > > Description > ------- > > Supported image name specified with private registry prefix. > > > Diffs > ----- > > include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7 > src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > d3eccd9902a7896d52e6c79b13bd389bb6380b8d > > Diff: https://reviews.apache.org/r/44674/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest" > > Tested with private registry localhost:80/ubuntu > > > Thanks, > > Gilbert Song > >
