----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45357/#review126760 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/gtest.hpp (lines 370 - 383) <https://reviews.apache.org/r/45357/#comment189826> Can we introduce the `ASSERT_*` versions before the `EXPECT_*` versions for consistency? Here and below. - Michael Park On March 26, 2016, 10:56 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45357/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 10:56 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4112 > https://issues.apache.org/jira/browse/MESOS-4112 > > > Repository: mesos > > > Description > ------- > > This RR is the item (3) for MESOS-4112. It adds HTTP respose > related macros that were not defined before: > 1. AWAIT_ASSERT_RESPONSE_STATUS_EQ_FOR > 2. AWAIT_ASSERT_RESPONSE_STATUS_EQ > 3. AWAIT_ASSERT_RESPONSE_BODY_EQ_FOR > 4. AWAIT_ASSERT_RESPONSE_BODY_EQ > 5. AWAIT_ASSERT_RESPONSE_HEADER_EQ_FOR > 6. AWAIT_ASSERT_RESPONSE_HEADER_EQ > (The above are the counterpart of AWAIT_EXPECT_RESPONSE_...) > > > Diffs > ----- > > 3rdparty/libprocess/include/process/gtest.hpp > 30d51d3704bd0ad82c6d21f1222d6158aaa61298 > > Diff: https://reviews.apache.org/r/45357/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
