----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45356/#review126762 -----------------------------------------------------------
Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not `EQ(true/false` in general, so that we would catch the use of `EXPECT_SOME_EQ(true, expr);` in `src/tests/health_check_tests.cpp` for example? Is there perhaps a separate patch that I don't have a pointer to? src/tests/cram_md5_authentication_tests.cpp (line 112) <https://reviews.apache.org/r/45356/#comment189827> I've added item (5) to [MESOS-4112](https://issues.apache.org/jira/browse/MESOS-4112), so that the transformation would be: ``` AWAIT_EQ(true, expr); ``` to ``` AWAIT_TRUE(expr); ``` - Michael Park On March 26, 2016, 10:35 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45356/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 10:35 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4112 > https://issues.apache.org/jira/browse/MESOS-4112 > > > Repository: mesos > > > Description > ------- > > This RR is a follow up to MESOS-4112 to replace `AWAIT_ASSERT_EQ(true/false` > with the newly defined `AWAIT_ASSERT_TRUE/_FALSE`. > > > Diffs > ----- > > src/tests/cram_md5_authentication_tests.cpp > 67f74e208ce138dc1e4667af108af3538b34aee9 > src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 > src/tests/group_tests.cpp ed10f1fe8a5cd2a353175e13ec3c464da69956f4 > src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc > > Diff: https://reviews.apache.org/r/45356/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
