> On April 3, 2016, 10:19 p.m., Kevin Klues wrote:
> > Looks great.  Glad we are finally able to catch these now!
> > 
> > Only comment would be on the summary line. We typically phrase the summary 
> > line in the past tense, with a period at the end, i.e.:
> > 
> > ```
> > Changed some non-ascii characters to ascii equivalent.
> > ```

The summary and commit message have been updated. Again thanks a lot for the 
detailed review and help!


- Yong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45660/#review126755
-----------------------------------------------------------


On April 3, 2016, 11:47 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45660/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 11:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
>     https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii 
> characters.
> 
> Note: The commit hook requires separate commits for libprocess and mesos.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
>   src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 
>   src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 
> 
> Diff: https://reviews.apache.org/r/45660/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to