> On April 4, 2016, 9:24 p.m., Benjamin Bannier wrote:
> > Ship It!

Thanks for doing this, I could easily imagine issues like this slipping throuh 
in the past since I had to look trice :D

It might be a good idea to get these fixes in before the hook.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126913
-----------------------------------------------------------


On April 4, 2016, 5:22 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45659/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 5:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd 
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi 
> Xiao.
> 
> 
> Bugs: MESOS-4033
>     https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is part of MESOS-4033: Add a commit hook for checking non-ascii 
> characters.
> 
> Note: The commit hook requires separate commits for libprocess and mesos.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp 
> a1bfc808eb1b1c372acb028019901f0ab3f15238 
> 
> Diff: https://reviews.apache.org/r/45659/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to