> On March 31, 2016, 3:43 p.m., Vinod Kone wrote: > > src/tests/environment.cpp, lines 767-771 > > <https://reviews.apache.org/r/45537/diff/1/?file=1320771#file1320771line767> > > > > should this be done by the test event listener as well?
Added a `TODO` as per discussion offline. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/#review126318 ----------------------------------------------------------- On April 4, 2016, 10:51 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45537/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 10:51 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-5044 > https://issues.apache.org/jira/browse/MESOS-5044 > > > Repository: mesos > > > Description > ------- > > Updated testing `Environment` to remove temp dirs after each test. > > > Diffs > ----- > > src/tests/environment.hpp 9932f7c530dee3180bbbdf6c06e1e0ec424b46b9 > src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 > > Diff: https://reviews.apache.org/r/45537/diff/ > > > Testing > ------- > > Verified that make check doesn't leak any temporary directories. > The exception seems to be some mesos-XXXXX directories created by example > frameworks. > > > Thanks, > > Joris Van Remoortere > >
