-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44364/
-----------------------------------------------------------

(Updated April 4, 2016, 11:41 p.m.)


Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Changes
-------

Added a more complete test to actually test that GPUs can be added to a 
container and accessed via 'nvidia-smi'


Summary (updated)
-----------------

Added tests for the Nvidia GPU isolator.


Bugs: MESOS-4863
    https://issues.apache.org/jira/browse/MESOS-4863


Repository: mesos


Description (updated)
-------

This commit also includes a test filter called 'NvidiaGpuFilter' that
checks for the existence of 'nvidia-smi' before running any tests that
contain the 'NVIDIA_GPU_' prefix.


Diffs (updated)
-----

  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp PRE-CREATION 
  src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 

Diff: https://reviews.apache.org/r/44364/diff/


Testing (updated)
-------

On an Nvidia GPU equipped machine:

```
sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" 
bin/mesos-tests.sh

SUCCESS
```

On a **non** Nvidia GPU equipped machine:

```
sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" 
bin/mesos-tests.sh

which: no nvidia-smi in (/sbin:/bin:/usr/sbin:/usr/bin)
--------------------------------------------------------------
No 'nvidia-smi' command found so no 'NvidiaGpu' tests will run
--------------------------------------------------------------
```


Thanks,

Kevin Klues

Reply via email to