----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review126980 -----------------------------------------------------------
src/cli/execute.cpp (lines 323 - 341) <https://reviews.apache.org/r/45370/#comment190111> let's keep this as a private branch for testing. This should not be merged into cli/execute.cpp src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp (line 77) <https://reviews.apache.org/r/45370/#comment190113> Add comments. src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (lines 105 - 106) <https://reviews.apache.org/r/45370/#comment190112> Use `const string&` - Gilbert Song On April 4, 2016, 2:21 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45370/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 2:21 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() for dvd isolator. > > > Diffs > ----- > > src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45370/diff/ > > > Testing > ------- > > The execute.cpp is mainly for test, will remove this file once test finished. > > > Thanks, > > Guangya Liu > >