----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45726/#review127023 -----------------------------------------------------------
Can you also add a test case for the empty string case? e.g., `--name=`. Do you think this should an Error case or not? - Jie Yu On April 5, 2016, 2:57 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45726/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 2:57 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5114 > https://issues.apache.org/jira/browse/MESOS-5114 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp > 6313b6b1f535822e1dee39f5780895a3691ff78c > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > e87bee24b8c57d15f3903ecd8d55e0e51e00f0ff > > Diff: https://reviews.apache.org/r/45726/diff/ > > > Testing > ------- > > Added a new test case that fails before the changes to `parse.hpp`. > > > Thanks, > > Michael Park > >
