----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45492/#review127177 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/docker.cpp (lines 1223 - 1224) <https://reviews.apache.org/r/45492/#comment190343> ``` {A, B} ``` src/slave/containerizer/external_containerizer.cpp (lines 1091 - 1092) <https://reviews.apache.org/r/45492/#comment190341> why not inline this? - Joris Van Remoortere On March 31, 2016, 10:21 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45492/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 10:21 a.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-5070 > https://issues.apache.org/jira/browse/MESOS-5070 > > > Repository: mesos > > > Description > ------- > > We now use the new ChildHooks instead of explicit options such > as setsid. > > > Diffs > ----- > > src/docker/docker.cpp 386f2f4afa51b3a78a3f0b4711018b38c4513e7b > src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 > src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 > src/slave/container_loggers/lib_logrotate.cpp > 1f228806da32832c9ca1ae4defcd1bdc154adc18 > src/slave/containerizer/docker.cpp c5007a311ae9c1766dd4522ccbddbdb506d4ae4e > src/slave/containerizer/external_containerizer.cpp > cf4384cce44172a028c890f52f71ceb8ae109383 > src/slave/containerizer/fetcher.cpp > 0992112a3d0f122915a3e7636de17c992610832f > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 1c8e231813c0579b79681c5d18b1f799a727ead7 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 323c84a3d960a196d8ba87f753814e9d43a07957 > src/slave/containerizer/mesos/isolators/posix/disk.cpp > dde958b252eae75563003ec15087b4231beb285a > src/slave/containerizer/mesos/launcher.cpp > a5c8c31b72773d0bd10b9d02675a01f1d641d41c > src/slave/containerizer/mesos/linux_launcher.cpp > 5028854fa003615f158120e030866b7ec4402b66 > src/tests/containerizer/launch_tests.cpp > 3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 > src/tests/containerizer/ns_tests.cpp > cd668ebb3b9461bee00dc338c288e5df6eb8fe31 > src/tests/containerizer/port_mapping_tests.cpp > e062daa9fcfc776144b48325daa1f1284c5e59a4 > src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 > > Diff: https://reviews.apache.org/r/45492/diff/ > > > Testing > ------- > > Tested entire chain see https://reviews.apache.org/r/45495/. > > > Thanks, > > Joerg Schad > >
