> On April 5, 2016, 12:28 p.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 136 > > <https://reviews.apache.org/r/45594/diff/2/?file=1326512#file1326512line136> > > > > Can you probably elaborate a bit more why a docker config file > > configuration is needed? > > > > I know it's most likely for pulling private registry docker files, but > > not quite obvious just by reading the help text.
Yeah, should mention private registry docker image pulling explicitly. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45594/#review127191 ----------------------------------------------------------- On April 5, 2016, 12:21 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45594/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 12:21 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-5065 > https://issues.apache.org/jira/browse/MESOS-5065 > > > Repository: mesos > > > Description > ------- > > Introduced a new agent flag docker_config. > > > Diffs > ----- > > docs/configuration.md 9ad0c2a201130ac23b22b1a844396dc97ec5ff70 > src/slave/flags.hpp 9ee7f349cc2bb3fa76141645f4a06fad57664367 > src/slave/flags.cpp fd9fbbaa911cc77a21574ba314c50ac226fa49ce > > Diff: https://reviews.apache.org/r/45594/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
