----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45529/ -----------------------------------------------------------
(Updated April 5, 2016, 11:15 p.m.) Review request for mesos and Joris Van Remoortere. Changes ------- Addressed review comment from Joris. Bugs: MESOS-5073 https://issues.apache.org/jira/browse/MESOS-5073 Repository: mesos Description ------- Do not leak roleSorter and quotaRoleSorter in Mesos allocator. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.hpp e979fdf60da1409d1c2d08f0e9f03cef067506dd src/master/allocator/mesos/hierarchical.cpp cd6b91edf3dde9bc4c978daefdfc83d7c3c69304 Diff: https://reviews.apache.org/r/45529/diff/ Testing ------- make check (OS X, clang trunk, not optimized) In https://reviews.apache.org/r/45534/ I add code requiring cleanup to `Sorter`s. Without this patch the cleanup code is never executed, but is with the patch. Thanks, Benjamin Bannier