----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45715/ -----------------------------------------------------------
(Updated April 6, 2016, 12:38 a.m.) Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. Changes ------- Addressed all of bmahler's comments. Also determined we needed to add access to /dev/nvidia-uvm in addition to /dev/nvidiactl. Summary (updated) ----------------- Fixed access to /dev/nvidia{ctl,-uvm} in Nvidia GPU isolator. Bugs: MESOS-5115 https://issues.apache.org/jira/browse/MESOS-5115 Repository: mesos Description (updated) ------- Previously, calls to 'nvidia-smi' would fail inside a container even if access to a GPU had been granted. Moreover, access to /dev/nvidiactl is actually required for a container to do anything useful with a GPU even if it has access to it. This patch explicitly grants/revokes access to /dev/nvidiactl and /dev/nvidia-uvm as GPUs are added and removed from a container in the Nvidia GPU isolator. Diffs (updated) ----- src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp b0f58035c7c819b42e5f249fadd97312f9e3ac7b Diff: https://reviews.apache.org/r/45715/diff/ Testing (updated) ------- Test in subsequent commit. Thanks, Kevin Klues