> On April 6, 2016, 10:10 a.m., Joseph Wu wrote: > > src/examples/long_lived_framework.cpp, lines 217-221 > > <https://reviews.apache.org/r/45800/diff/1/?file=1327282#file1327282line217> > > > > Would be nice to log something here. > > Anand Mazumdar wrote: > Logging an `ERROR` would be useful. I had copied over from the old > interface that did not use to log anything. Does this sound reasonable to you?
Sounds good. (Logging the `RESCIND` event might also be useful.) > On April 6, 2016, 10:10 a.m., Joseph Wu wrote: > > src/examples/long_lived_framework.cpp, line 593 > > <https://reviews.apache.org/r/45800/diff/1/?file=1327282#file1327282line593> > > > > Does the HTTP scheduler driver initialize glog (like the old scheduler > > driver does)? > > Anand Mazumdar wrote: > It doesn't. We should ideally initialize logging inside the framework > itself. The only consequence of not initializing glog is that glog will print a warning the first time we hit a `LOG(...) << ...` line. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127365 ----------------------------------------------------------- On April 6, 2016, 10:45 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45800/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 10:45 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4982 > https://issues.apache.org/jira/browse/MESOS-4982 > > > Repository: mesos > > > Description > ------- > > See summary. Also removed the AuthN code. Once, the library > supports AuthN we can bring it back. > > > Diffs > ----- > > src/examples/long_lived_framework.cpp > ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 > > Diff: https://reviews.apache.org/r/45800/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
