----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review127563 -----------------------------------------------------------
Fix it, then Ship it! It's not mentioned in the test summary so could you also verify the formatting in a markdown viewer? We should follow this up with https://issues.apache.org/jira/browse/MESOS-5140. docs/configuration.md (line 1746) <https://reviews.apache.org/r/44950/#comment190936> s/range/ranges/ docs/configuration.md (lines 1746 - 1747) <https://reviews.apache.org/r/44950/#comment190939> Also mention "Valid project IDs range from 1 to max(uint32)" before "(default: ...)" docs/configuration.md (line 1747) <https://reviews.apache.org/r/44950/#comment190938> s/The default is `[5000-10000]`/(default: `[5000-10000]`)/ so it looks the same as the rest of doc. docs/mesos-containerizer.md (line 94) <https://reviews.apache.org/r/44950/#comment190940> "not be terminated by the containerizer." docs/mesos-containerizer.md (line 106) <https://reviews.apache.org/r/44950/#comment190945> Mention: 1. The XFS disk isolator is functionally similar to Posix disk isolator but avoids the `du` cost. It's not recommended to use them together, even though they shouldn't interfere with each other. 2. The XFS disk isolator doesn't natively currently support accounting-only mode like Posix isolator does. (I guess we don't need to mention the `gqnoenforce` option just yet) 3. The slave flags mentioned in the "Posix Disk Isolator" section are not applicable to the XFS disk isolator. Change the wording as you see fit. - Jiang Yan Xu On April 6, 2016, 3:36 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44950/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 3:36 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOs-4828 > https://issues.apache.org/jira/browse/MESOs-4828 > > > Repository: mesos > > > Description > ------- > > Add XFS disk isolator documentation. > > > Diffs > ----- > > docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c > docs/mesos-containerizer.md 2fde74362f35568bb944da80a1db17e6d3ba9d7b > > Diff: https://reviews.apache.org/r/44950/diff/ > > > Testing > ------- > > Make check. Source inspection. > > > Thanks, > > James Peach > >
