> On April 5, 2016, 6:40 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 219
> > <https://reviews.apache.org/r/45491/diff/2/?file=1320641#file1320641line219>
> >
> >     Do we use this `operator() ()` style elsewhere?

If you mean `operator()()` (vs `operator() ()`) then it is fixed.
Or were you refering to the pattern using `operator()()` in order to expose 
private functions?


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45491/#review127172
-----------------------------------------------------------


On April 7, 2016, 4:55 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45491/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 4:55 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5070
>     https://issues.apache.org/jira/browse/MESOS-5070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously the subprocess interface supported a several options for the
> child process such as setsid. In order to make the interface more
> flexible we refactored such options into a vector of ChildHooks.
> In order not to allow arbitrary code inside a ChildHook it has to be
> constructed via pre-defined factory methods.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 5435ddda1fd7dfcff1a0b28f2abe35feb707ceeb 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 8a3fe5526f480187441a8aee2c72636bec3e2b2d 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 727e940f12643974de4ff2734fba431b285b5de3 
> 
> Diff: https://reviews.apache.org/r/45491/diff/
> 
> 
> Testing
> -------
> 
> Tested entire chain see https://reviews.apache.org/r/45495/.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to