----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43515/#review127788 -----------------------------------------------------------
Could you please run the test in repetition? src/tests/master_tests.cpp (line 1036) <https://reviews.apache.org/r/43515/#comment191176> Why do you settle? src/tests/master_tests.cpp (line 1037) <https://reviews.apache.org/r/43515/#comment191174> Let's extract this value from master flags: it's more reliable if someone decides to change interval through flags in this test. src/tests/master_tests.cpp (line 1042) <https://reviews.apache.org/r/43515/#comment191175> Move it up after `advance()`? - Alexander Rukletsov On Feb. 12, 2016, 6:36 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43515/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2016, 6:36 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4165 > https://issues.apache.org/jira/browse/MESOS-4165 > > > Repository: mesos > > > Description > ------- > > Speed up MasterTest.MasterInfoOnReElection. > > > Diffs > ----- > > src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 > > Diff: https://reviews.apache.org/r/43515/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
