-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45917/#review127819
-----------------------------------------------------------
I think to test this you need to revert the changes made to SSL tests?
Also for CMake, you can add the -D flag by adding a "add_definitions(-D
HTTP_PARSER_STRICT=0)" to
3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template. @AlexClemner
is this the right way to add -D flag to http parser compilation?
Additionaly, while looking through the CMAKE files I realized that there are
still references to the old http parser library:
```
➜ mesos git:(vinod/release_support_doc) ack RY_UPDATE 3rdparty
3rdparty/libprocess/3rdparty/CMakeLists.txt
117:set(RY_UPDATE_CMD ${CMAKE_COMMAND} -E copy
${PROCESS_3RD_SRC}/http-parser/CMakeLists.txt.template
${HTTP_PARSER_ROOT}/CMakeLists.txt)
174: UPDATE_COMMAND ${RY_UPDATE_CMD}
➜ mesos git:(vinod/release_support_doc) ack Ryan 3rdparty
3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template
17:# Builds Ryan Dahl's http-parser project.
3rdparty/libprocess/3rdparty/Makefile.am
86: # Convenience library for Ryan Dahl's HTTP parser.
```
Can you make sure to clean these up as well?
- Vinod Kone
On April 8, 2016, 9:22 a.m., Zhiwei Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45917/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 9:22 a.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Bugs: MESOS-5063
> https://issues.apache.org/jira/browse/MESOS-5063
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disable http-parser strict mode to allow flexible http header fields.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am
> 217283cd3ce6df699b63dc5b8fb3aab0c6debd04
>
> Diff: https://reviews.apache.org/r/45917/diff/
>
>
> Testing
> -------
>
> ./configure --enable-ssl --enable-libevent
> make distcheck
>
>
> Thanks,
>
> Zhiwei Chen
>
>
