-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45854/#review127887
-----------------------------------------------------------


Ship it!





src/tests/common/http_tests.cpp (lines 162 - 163)
<https://reviews.apache.org/r/45854/#comment191248>

    I'm a little hesitant about using revocable gpus here given that it's not 
clear how it would work, but I suppose there is no harm in it for this test.


- Ben Mahler


On April 8, 2016, 5:54 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45854/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 5:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5136
>     https://issues.apache.org/jira/browse/MESOS-5136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This includes updating some tests that parse this JSON and look for
> specific values for all of its fields.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 3748c71686c696c47f93a81e3434bbb55448e334 
>   src/tests/common/http_tests.cpp ac6322d7fb58adf7a615c517496d08dee3bf0081 
>   src/tests/dynamic_weights_tests.cpp 
> e36a45fa18d163430df1c9dc72d2372aee9b44e6 
>   src/tests/role_tests.cpp 056359bbe6a02bb129bfa2ce371e82cd3aa4c984 
> 
> Diff: https://reviews.apache.org/r/45854/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to