----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45942/#review127891 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On April 8, 2016, 8:36 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45942/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 8:36 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-5157 > https://issues.apache.org/jira/browse/MESOS-5157 > > > Repository: mesos > > > Description > ------- > > Updated the webui to include GPU metrics. > > > Diffs > ----- > > src/webui/master/static/framework.html > ee42d1ab841a4c42d95512ee60d577b1bbb66bc8 > src/webui/master/static/frameworks.html > 15ff1e9cb6c70df8df47a1b939681abde591e010 > src/webui/master/static/home.html a691084f4992cda65734f5fee3b2f38349737b83 > src/webui/master/static/js/controllers.js > f92affab41f8418cd7e5ea25561a182a1761fd79 > src/webui/master/static/offers.html > 01213e9582f50072a9c729782271269f72972d28 > src/webui/master/static/slave.html 4419f7c166e8768040dab7dbc6fb64e1382ad272 > src/webui/master/static/slave_executor.html > 5acb676390fe4ed17369143c5aaaaa13202c0981 > src/webui/master/static/slave_framework.html > 4b2b1562f38f002b4659b4a883249f0469307323 > src/webui/master/static/slaves.html > 0cb125a7d95ccc7770916cbffa052f43e8ea3d2c > > Diff: https://reviews.apache.org/r/45942/diff/ > > > Testing > ------- > > Manually opened the web UI, clicked around to make sure all the GPU metrics > now showed up. > Also looked at "Inspect Element" to verify that there were no javascript > errors when loading. > > Specifically: > ``` > * The Resources section in the left sidebar of the main page > * The Resources section of the table in the Frameworks tab > * The Resources section of the table in the Slaves tab > * The Resources section of the table in the Offers tab > ``` > > > Thanks, > > Kevin Klues > >