-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45488/#review127911
-----------------------------------------------------------


Ship it!




Ship It!

- Ben Mahler


On March 30, 2016, 2:49 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45488/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 2:49 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Zero'ing the input buffer before receiving data is unnecessary.
> Moreover, keeping the `memset` around is confusing, because it makes
> the API contract of Socket.recv() less clear.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 
> feaffa4334422ec3964f8d079f570061eaf390d2 
> 
> Diff: https://reviews.apache.org/r/45488/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to