-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44949/#review127923
-----------------------------------------------------------


Ship it!




Only some nits which I'll fix when committing.


src/tests/containerizer/xfs_quota_tests.cpp (line 344)
<https://reviews.apache.org/r/44949/#comment191301>

    s/that/than/.



src/tests/containerizer/xfs_quota_tests.cpp (line 345)
<https://reviews.apache.org/r/44949/#comment191299>

    s/consumed/consume/.



src/tests/containerizer/xfs_quota_tests.cpp (line 597)
<https://reviews.apache.org/r/44949/#comment191300>

    A little explanaion of `2u` would be make it clearer.



src/tests/containerizer/xfs_quota_tests.cpp (line 654)
<https://reviews.apache.org/r/44949/#comment191305>

    Let's do `count=1`, same as the previous test.


- Jiang Yan Xu


On April 7, 2016, 2:50 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44949/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 2:50 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
>     https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add basic XFS disk isolator tests by cloning the POSIX disk isolator
> tests and making minor changes for the differences in semantics.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44949/diff/
> 
> 
> Testing
> -------
> 
> Make check. Manual testing.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Reply via email to