> On April 9, 2016, 7:29 a.m., Anand Mazumdar wrote:
> > src/slave/slave.cpp, line 5640
> > <https://reviews.apache.org/r/44427/diff/1/?file=1281966#file1281966line5640>
> >
> >     We typically don't spill partial arguments from a function invocation.
> >     
> >     How about:
> >     
> >     ```cpp
> >     executorPath = os::realpath(
> >       path::join(slave->flags.launcher_dir, ..));
> >     ```

Agree, but I think it should 4 space indent, see the followings as example:
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L5901:L5902
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L5955:L5956


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44427/#review127910
-----------------------------------------------------------


On March 6, 2016, 12:37 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44427/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 12:37 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added --http_command_executor flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
> 
> Diff: https://reviews.apache.org/r/44427/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to