> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote:
> > src/tests/hook_tests.cpp, line 396
> > <https://reviews.apache.org/r/42241/diff/3/?file=1200496#file1200496line396>
> >
> >     Is there a need to explicitly invoke `Clock::resume()` here? If not, 
> > kill it.
> 
> Alexander Rukletsov wrote:
>     Let's leave the test with resumed clock for consistency.
> 
> Anand Mazumdar wrote:
>     Alex, what consistency are you referring to here? Does this file follow 
> the pattern of explicitly doing so?
> 
> Alexander Rukletsov wrote:
>     We've discussed it with BenM here recently: 
> https://reviews.apache.org/r/44994/#comment186808
> 
> Anand Mazumdar wrote:
>     Don't we explicitly resume the clock at the end of the test if an 
> assertion fails making the `resume` call redundant? 
> https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/gtest.hpp#L47
>     
>     Looks like I am missing something here.

Change the test here to explicitly destroy container instead of waiting for 
timeout.


- Jian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
-----------------------------------------------------------


On 四月 9, 2016, 2:45 p.m., Jian Qiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> -----------------------------------------------------------
> 
> (Updated 四月 9, 2016, 2:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
>     https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -----
> 
>   src/tests/hook_tests.cpp 0bbb7ac9e80234920814e34286ea0da9b648ebe3 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> -------
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Reply via email to