> On April 9, 2016, 12:45 a.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, lines 277-281 > > <https://reviews.apache.org/r/45953/diff/1/?file=1337639#file1337639line277> > > > > HOSTNAME max length might be variable. Will the system below checks the > > length as well. Why bother adding this additional check?
My bad. Didn't realize sethostname is returning EINVAL if hostname exceeds MAXHOSTNAMELEN. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45953/#review127935 ----------------------------------------------------------- On April 8, 2016, 9:59 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45953/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 9:59 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-4922 > https://issues.apache.org/jira/browse/MESOS-4922 > > > Repository: mesos > > > Description > ------- > > Adding a stout interface for `sethostname` system call in linux. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > 3c80910653ad2f3b663f19395f10214029f1a75e > > Diff: https://reviews.apache.org/r/45953/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
