----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46033/#review128127 -----------------------------------------------------------
Fix it, then Ship it! src/master/quota_handler.cpp (line 265) <https://reviews.apache.org/r/46033/#comment191502> To be consistent with the above message (i.e. First general Failed to do ... , : , detailed error. "Failed to validate set quota request JSON: Can not set quota for role '" + quotaInfo.role() + "' that already has quota"); src/master/quota_handler.cpp (line 267) <https://reviews.apache.org/r/46033/#comment191501> s/ already/already - Joerg Schad On April 11, 2016, 2:49 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46033/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 2:49 p.m.) > > > Review request for mesos and Joerg Schad. > > > Repository: mesos > > > Description > ------- > > When an error is not related to the whole request (e.g., parsing, > converting to protobuf), but to its part (e.g., unknown role), it > seems unnecessary to include the complete request body into the > error response. > > > Diffs > ----- > > src/master/quota_handler.cpp 88247d6525b2aaeb58eea77376fd4ed8e0c653c3 > > Diff: https://reviews.apache.org/r/46033/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > >
