> On April 11, 2016, 5:02 p.m., Jie Yu wrote: > > Instead of creating a new helper binary, can we use the mesos-containerizer > > binary? > > > > We need to namespace the subcommand properly to avoid conflicts. We can use > > 'network-cni-setup' as the name of the subcommand. > > Avinash sridharan wrote: > So just add a subcommand for the mesos containerizer binary here: > > https://github.com/apache/mesos/blob/4d2b1b793e07a9c90b984ca330a3d7bc9e1404cc/src/slave/containerizer/mesos/main.cpp#L28 > ? > > This makes sense.
Yes. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45955/#review128161 ----------------------------------------------------------- On April 8, 2016, 10:34 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45955/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 10:34 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-4922 > https://issues.apache.org/jira/browse/MESOS-4922 > > > Repository: mesos > > > Description > ------- > > This will be used by the `network/cni` isolator to setup hostname and > various network files within the container UTS and mnt namespace. > > > Diffs > ----- > > src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 > src/slave/containerizer/mesos/isolators/network/cni/helper.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45955/diff/ > > > Testing > ------- > > make > > * Ran mesos-execute with the a single master/slave setup that the container > attaches to the CNI network correctly and that its network files and hostname > are setup correctly. > > > Thanks, > > Avinash sridharan > >
