> On April 11, 2016, 3:19 p.m., Alexander Rukletsov wrote: > > Could you please briefly explain the problem with the globbing in the > > description? > > > > Btw, I was unaware of that patch and filed > > https://reviews.apache.org/r/46034/ . I'll discard it in favour of your > > patch.
I had a more detailed description in the JIRA ticket, but I've copied the description from your review. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45984/#review128134 ----------------------------------------------------------- On April 11, 2016, 5:45 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45984/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 5:45 p.m.) > > > Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-5162 > https://issues.apache.org/jira/browse/MESOS-5162 > > > Repository: mesos > > > Description > ------- > > Some symbols, e.g., '*' can be expanded by the shell altering the > original line and hence leading to false positives. > > > Diffs > ----- > > support/hooks/commit-msg d3f10c886a654aa8d8364faddf2e50dc7fe82058 > > Diff: https://reviews.apache.org/r/45984/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
