> On April 9, 2016, 12:16 a.m., Ben Mahler wrote: > > Looks pretty good, thanks! > > > > Could you also add tests that mirror the task label tests? > > > > ``` > > $ grep -R TEST src/tests | grep TaskLabels > > src/tests/master_tests.cpp:TEST_F(MasterTest, TaskLabels) > > src/tests/slave_tests.cpp:TEST_F(SlaveTest, TaskLabels) > > ```
It seems like `/state` endpoint on master is constructed using the `Task` message in src/message/message.proto instead of `TaskInfo` in mesos.proto, so I guess I'd also need to define a `optional Labels executor_labels` field to the `Task` message in order to make executor_labels show up in master. Does this sound right? - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/#review127918 ----------------------------------------------------------- On April 1, 2016, 1:42 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45572/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 1:42 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-5029 > https://issues.apache.org/jira/browse/MESOS-5029 > > > Repository: mesos > > > Description > ------- > > Add labels to ExecutorInfo and deprecate source. > > > Diffs > ----- > > CHANGELOG b90078d41357c29c9102df00a735bde460e797bb > include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f > include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 > src/tests/oversubscription_tests.cpp > ba036810758d99a6fb0034c5e2bc7829e2343a44 > > Diff: https://reviews.apache.org/r/45572/diff/ > > > Testing > ------- > > Added a test in oversubciption_tests to make sure executor labels are visible > to ResourceEstimator and QoSController. > > > Thanks, > > Zhitao Li > >
