----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46044/#review128246 -----------------------------------------------------------
Bad patch! Reviews applied: [46044, 45927, 45926, 45925] Failed command: ./support/apply-review.sh -n -r 45927 Error: 2016-04-11 21:02:49 URL:https://reviews.apache.org/r/45927/diff/raw/ [3922/3922] -> "45927.patch" [1] error: patch failed: src/cli/execute.cpp:63 error: src/cli/execute.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/12464/console - Mesos ReviewBot On April 11, 2016, 7:01 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46044/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 7:01 p.m.) > > > Review request for mesos, Anand Mazumdar and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Pass complete `flags` instance rather than each flag value separately > to `CommandScheduler` in mesos-execute for brevity. > > > Diffs > ----- > > src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40 > > Diff: https://reviews.apache.org/r/46044/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > make check > > Additionally manually tested mesos-execute with both responsive and > unresponsive (https://github.com/rukletsov/unresponsive-process) tasks: > ./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="sleep 10" > --env='{"GLOG_v": "2"}' --kill_after=2secs > ./src/mesos-execute --master=127.0.0.1:5050 --name=test > --command="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": "2"}' > --kill_after=2secs > > > Thanks, > > Alexander Rukletsov > >
