----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review128276 -----------------------------------------------------------
src/cli/execute.cpp (line 488) <https://reviews.apache.org/r/45731/#comment191703> use tokenize instead. src/cli/execute.cpp (line 504) <https://reviews.apache.org/r/45731/#comment191704> Ditto on using tokenize. src/cli/execute.cpp (line 509) <https://reviews.apache.org/r/45731/#comment191705> You should set DockerInfo network mode as well to 'USER'? - Jie Yu On April 9, 2016, 2:53 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45731/ > ----------------------------------------------------------- > > (Updated April 9, 2016, 2:53 a.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-5117 > https://issues.apache.org/jira/browse/MESOS-5117 > > > Repository: mesos > > > Description > ------- > > Introduced '--networks' flag to mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp df93e92252addaa794898ba95604eb2f91284b87 > > Diff: https://reviews.apache.org/r/45731/diff/ > > > Testing > ------- > > Ran the following command: > `sudo src/mesos-execute --master=192.168.122.171:5050 --name=test > --docker_image=library/busybox --command="sleep 30" --shell=true > --networks=net1,net2` > > The created container successfully joined the CNI networks `net1` and `net2`. > > > Thanks, > > Qian Zhang > >