> On April 11, 2016, 10:42 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 1947-1954 > > <https://reviews.apache.org/r/46028/diff/1/?file=1339343#file1339343line1947> > > > > The implication of this comment (regardless of your changes) seems to > > be that the socket is an outbound socket? Is that true?
This function is called for both inbound and outbound sockets, and AFAICS similar comments would apply (i.e., calling `shutdown()` means that any `recv` callback will see EOF on the socket). Updated the comment accordingly. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/#review128267 ----------------------------------------------------------- On April 11, 2016, 2:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46028/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 2:35 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Improved comments in SocketManager::next(). > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > > Diff: https://reviews.apache.org/r/46028/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
