-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/#review128368
-----------------------------------------------------------


Fix it, then Ship it!




I'll change the wording and commit shortly.


src/tests/master_allocator_tests.cpp (lines 669 - 670)
<https://reviews.apache.org/r/43329/#comment191804>

    How about:
    ```
    // Set the `executor_shutdown_grace_period` to a small value so that
    // the agent does not wait for executors to clean up for too long.
    ```


- Alexander Rukletsov


On April 9, 2016, 3:39 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43329/
> -----------------------------------------------------------
> 
> (Updated April 9, 2016, 3:39 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3775
>     https://issues.apache.org/jira/browse/MESOS-3775
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speeded up MasterAllocatorTest.SlaveLost test.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_allocator_tests.cpp 
> 404ff098baf89bf2a1c6e32424d591a6ea1a093c 
> 
> Diff: https://reviews.apache.org/r/43329/diff/
> 
> 
> Testing
> -------
> 
> ```
> [----------] 1 test from MasterAllocatorTest/0, where TypeParam = 
> mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAlloca
> torProcess<mesos::internal::master::allocator::DRFSorter, 
> mesos::internal::master::allocator::DRFSorter> >
> [ RUN      ] MasterAllocatorTest/0.SlaveLost
> [       OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
> [----------] 1 test from MasterAllocatorTest/0 (369 ms total)
> 
> [----------] 1 test from MasterAllocatorTest/1, where TypeParam = 
> mesos::internal::tests::Module<mesos::master::allocator::Allocator, 
> (mesos::internal::tests::ModuleID)6>
> [ RUN      ] MasterAllocatorTest/1.SlaveLost
> [       OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
> [----------] 1 test from MasterAllocatorTest/1 (120 ms total)
> ```
> 
> Tested repeatedly with:
> ```
> ./bin/mesos-tests.sh --gtest_filter=MasterAllocatorTest*.SlaveLost 
> --gtest_repeat=1000 --gtest_break_on_failure'
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Reply via email to