-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46085/#review128391
-----------------------------------------------------------




src/tests/slave_tests.cpp (line 1843)
<https://reviews.apache.org/r/46085/#comment191826>

    As the .json endpoint is deprecated, I am not sure whether we need to tests 
those...
    But just my opinion


- Joerg Schad


On April 12, 2016, 1:06 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46085/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 1:06 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
> 
> 
> Bugs: MESOS-5152
>     https://issues.apache.org/jira/browse/MESOS-5152
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authentication to agent's /monitor/statistics endpoint.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059 
>   src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
>   src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 
> 
> Diff: https://reviews.apache.org/r/46085/diff/
> 
> 
> Testing
> -------
> 
> make check (clang w/o optimization, OS X)
> 
> Additionally confirmed with an actual test cluster setup.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to