----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review128423 -----------------------------------------------------------
Fix it, then Ship it! I'll fix the last nit and commit shortly. src/tests/scheduler_tests.cpp (line 1075) <https://reviews.apache.org/r/43321/#comment191848> Any reason why not resuming right after advancing? - Alexander Rukletsov On April 9, 2016, 9:17 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43321/ > ----------------------------------------------------------- > > (Updated April 9, 2016, 9:17 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-4175 > https://issues.apache.org/jira/browse/MESOS-4175 > > > Repository: mesos > > > Description > ------- > > Speeded up SchedulerTest.Decline by advancing the clock. > > > Diffs > ----- > > src/tests/scheduler_tests.cpp 7956da3480c06637b6893e05f2ed92c4bb8d089f > > Diff: https://reviews.apache.org/r/43321/diff/ > > > Testing > ------- > > sudo make check -j2 GTEST_FILTER='ContentType/SchedulerTest.Decline/* > > ```sh > [ RUN ] ContentType/SchedulerTest.Decline/0 > [ OK ] ContentType/SchedulerTest.Decline/0 (114 ms) > [ RUN ] ContentType/SchedulerTest.Decline/1 > [ OK ] ContentType/SchedulerTest.Decline/1 (98 ms) > ``` > > Repeatedly tested with: > > ```sh > ./bin/mesos-tests.sh --gtest_filter=ContentType/SchedulerTest.Decline/* > --gtest_repeat=1000 --gtest_break_on_failure > ``` > > > Thanks, > > Shuai Lin > >
