-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46009/#review128420
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/Makefile.am (line 48)
<https://reviews.apache.org/r/46009/#comment191843>

    Are you missing an entry in `3rdparty/libprocess/3rdparty/Makefile.am`?



3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp (line 22)
<https://reviews.apache.org/r/46009/#comment191844>

    Please move this above the `EnvTest` class declaration.



3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp (lines 26 - 27)
<https://reviews.apache.org/r/46009/#comment191845>

    Please use plain names that are self descriptive.



3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp (line 35)
<https://reviews.apache.org/r/46009/#comment191846>

    If on L36 you assume the value, should you not `ASSERT_SOME` here?
    
    Same below.



3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp (line 38)
<https://reviews.apache.org/r/46009/#comment191847>

    s/set environment/set the environment/



3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp (lines 22 - 23)
<https://reviews.apache.org/r/46009/#comment191849>

    This seems generally useful?
    I think I've even seen it in other reviews?
    Why is it burried in a test?


- Joris Van Remoortere


On April 11, 2016, 8:31 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46009/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 8:31 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout:[1/2] Added simple tests for `os::` functions.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 400c6dc451602926f93b22713af8c66d7ca59ca6 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> c9d331df2f4496183b5734d2434413f68b9c1b4b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp 
> d5a96ad6b8b1c09b4f016e0c8e3e5c5672b55ef3 
> 
> Diff: https://reviews.apache.org/r/46009/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to