-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45014/#review128441
-----------------------------------------------------------




src/slave/http.cpp (line 669)
<https://reviews.apache.org/r/45014/#comment191861>

    Why creating a helper in Slave? I don't think that's necessary. We have a 
helper 'usage' in Slave because other component (e.g., ResourceEstimator) wants 
to use that besides the http endpoint.



src/slave/slave.cpp (lines 5221 - 5222)
<https://reviews.apache.org/r/45014/#comment191862>

    We don't use typedef typically in our code base for explicitness. Please 
use explicit type instead.



src/slave/slave.cpp (line 5250)
<https://reviews.apache.org/r/45014/#comment191863>

    Please add a CHECK to make sure the sizes of the lists are the same



src/slave/slave.cpp (lines 5251 - 5253)
<https://reviews.apache.org/r/45014/#comment191864>

    Please use 'auto'.


- Jie Yu


On April 12, 2016, 9:11 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45014/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 9:11 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4891
>     https://issues.apache.org/jira/browse/MESOS-4891
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It returns both resource statistics and container status.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059 
>   src/slave/slave.hpp 76f3aff394e5cecc54dcb3065cb872e238bc228e 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
>   src/tests/containerizer.hpp efc1ca87c00b04d70efd1e3f6acf4e763132d6b0 
>   src/tests/containerizer.cpp 4c7f5a26d38222daf013bd3ca9a133e12d7bf338 
>   src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 
> 
> Diff: https://reviews.apache.org/r/45014/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Reply via email to