-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45941/#review128502
-----------------------------------------------------------


Fix it, then Ship it!




Thanks! Will get this committed shortly.


src/slave/slave.cpp (line 4972)
<https://reviews.apache.org/r/45941/#comment191911>

    newline here
    
    missing an 'i' in 'Oversubscrbable'



src/slave/slave.cpp (line 4976)
<https://reviews.apache.org/r/45941/#comment191912>

    s/.get()./->/


- Ben Mahler


On April 9, 2016, 5:20 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45941/
> -----------------------------------------------------------
> 
> (Updated April 9, 2016, 5:20 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5131
>     https://issues.apache.org/jira/browse/MESOS-5131
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add check in agent for incorrect oversubscribed resource.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
> 
> Diff: https://reviews.apache.org/r/45941/diff/
> 
> 
> Testing
> -------
> 
> Running existing test, and verify manually that offending resource crashes 
> the agent.
> 
> (Any suggestion to test `CHECK` is welcomed).
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Reply via email to