-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/#review128721
-----------------------------------------------------------


Fix it, then Ship it!





src/CMakeLists.txt (line 143)
<https://reviews.apache.org/r/45217/#comment192186>

    let's call it docker/volume isolator and put it under 
docker/volume/isolator.hpp|cpp



src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp (line 25)
<https://reviews.apache.org/r/45217/#comment192187>

    Kill one line here.



src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp (line 30)
<https://reviews.apache.org/r/45217/#comment192188>

    Let's call it `DockerVolumeIsolatorProcess`


- Jie Yu


On April 13, 2016, 3:18 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45217/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 3:18 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented docker volume driver isolator interface.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45217/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to