-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45370/#review128741
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (line 110)
<https://reviews.apache.org/r/45370/#comment192206>

    options in ExternalMount is a repeated Parameter, which has key and value. 
Looks like this needs some refactoring.



src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (line 113)
<https://reviews.apache.org/r/45370/#comment192207>

    other `--flag` params are computed elsewhere (e.g. DvdClient::mount); 
should do the same here. Just construct Parameters instead


- James DeFelice


On April 4, 2016, 9:21 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45370/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 9:21 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented prepare() for dvd isolator.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45370/diff/
> 
> 
> Testing
> -------
> 
> The execute.cpp is mainly for test, will remove this file once test finished.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to